search

OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup
https://docs.openzeppelin.com/contracts-cairo
MIT License
826 stars 339 forks source link

Add `is_valid_secp256_signature` support #1189

Closed ericnordelo closed 3 weeks ago

ericnordelo commented 3 weeks ago

Fixes #987

PR Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.61%. Comparing base (9ad6d13) to head (b763c9f). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/account/src/utils/secp256_point.cairo 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1189 +/- ## ========================================== + Coverage 91.57% 91.61% +0.03% ========================================== Files 47 47 Lines 1223 1228 +5 ========================================== + Hits 1120 1125 +5 Misses 103 103 ``` | [Files with missing lines](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1189?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin) | Coverage Δ | | |---|---|---| | [packages/account/src/eth\_account.cairo](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1189?src=pr&el=tree&filepath=packages%2Faccount%2Fsrc%2Feth_account.cairo&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin#diff-cGFja2FnZXMvYWNjb3VudC9zcmMvZXRoX2FjY291bnQuY2Fpcm8=) | `98.27% <ø> (ø)` | | | [packages/account/src/utils.cairo](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1189?src=pr&el=tree&filepath=packages%2Faccount%2Fsrc%2Futils.cairo&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin#diff-cGFja2FnZXMvYWNjb3VudC9zcmMvdXRpbHMuY2Fpcm8=) | `87.50% <ø> (ø)` | | | [packages/account/src/utils/signature.cairo](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1189?src=pr&el=tree&filepath=packages%2Faccount%2Fsrc%2Futils%2Fsignature.cairo&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin#diff-cGFja2FnZXMvYWNjb3VudC9zcmMvdXRpbHMvc2lnbmF0dXJlLmNhaXJv) | `87.50% <100.00%> (+4.16%)` | :arrow_up: | | [packages/testing/src/constants.cairo](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1189?src=pr&el=tree&filepath=packages%2Ftesting%2Fsrc%2Fconstants.cairo&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin#diff-cGFja2FnZXMvdGVzdGluZy9zcmMvY29uc3RhbnRzLmNhaXJv) | `100.00% <100.00%> (ø)` | | | [packages/testing/src/signing.cairo](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1189?src=pr&el=tree&filepath=packages%2Ftesting%2Fsrc%2Fsigning.cairo&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin#diff-cGFja2FnZXMvdGVzdGluZy9zcmMvc2lnbmluZy5jYWlybw==) | `100.00% <100.00%> (ø)` | | | [packages/account/src/utils/secp256\_point.cairo](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1189?src=pr&el=tree&filepath=packages%2Faccount%2Fsrc%2Futils%2Fsecp256_point.cairo&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin#diff-cGFja2FnZXMvYWNjb3VudC9zcmMvdXRpbHMvc2VjcDI1Nl9wb2ludC5jYWlybw==) | `81.25% <85.71%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1189?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1189?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin). Last update [9ad6d13...b763c9f](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1189?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin).