OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup
https://docs.openzeppelin.com/contracts-cairo
MIT License
826 stars 339 forks source link

Test token hooks #1198

Closed ggonzalez94 closed 1 week ago

ggonzalez94 commented 2 weeks ago

Fixes #1062

PR Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.56%. Comparing base (8404eb9) to head (2f0899d). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1198 +/- ## ========================================== - Coverage 91.57% 91.56% -0.02% ========================================== Files 47 47 Lines 1223 1233 +10 ========================================== + Hits 1120 1129 +9 - Misses 103 104 +1 ``` [see 6 files with indirect coverage changes](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1198/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1198?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1198?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin). Last update [8404eb9...2f0899d](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1198?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin).
ggonzalez94 commented 1 week ago

Comments have been incorporated + renamed the new mocks to Snake<ERCStandard>MockWithHooks to be more consistent with the rest of the mocks in the same file. This is now ready for final review and merge