search

OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup
https://docs.openzeppelin.com/contracts-cairo
MIT License
826 stars 339 forks source link

Bump snforge, unignore tests #1203

Closed andrew-fleming closed 1 week ago

andrew-fleming commented 1 week ago

Bump snforge to v0.33.0 which allows some of the previously ignored tests to successfully run (namely, ENTRYPOINT_NOT_FOUND tests with dispatchers). It might be worth waiting for the package release on scarbs before merging

PR Checklist

ericnordelo commented 1 week ago

Great news @andrew-fleming. The PR looks good to me, but let's not forget to add the CHANGELOG entry for bumping the snfoundry version.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.03%. Comparing base (6e3d8aa) to head (26153f8). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1203 +/- ## ======================================= Coverage 92.03% 92.03% ======================================= Files 49 49 Lines 1394 1394 ======================================= Hits 1283 1283 Misses 111 111 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1203?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1203?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin). Last update [6e3d8aa...26153f8](https://app.codecov.io/gh/OpenZeppelin/cairo-contracts/pull/1203?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenZeppelin).