Cairo implementation of EIP-4626

OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup

https://docs.openzeppelin.com/contracts-cairo

MIT License

813 stars 329 forks source link

Cairo implementation of EIP-4626 #277

Open FilipLaurentiu opened 2 years ago

FilipLaurentiu commented 2 years ago

Full details of the standard OpenZeppelin has always offered the best implementations for different standards in Ethereum and now in Starknet. EIP-4626 it's the new popular standard for tokenized vaults and many projects already use it for their Vaults on Ethereum.

Starknet is becoming more and more popular and many projects need an implementation of this standard on which to rely. OZ has always provided well tested tools with no security issues.

An implementation from OZ would save a lot of development time and money

There are already two implementation for this standard in Cairo https://github.com/koloz193/ERC4626 https://github.com/milancermak/cairo-4626

EvolveArt commented 2 years ago

A few thoughts on this:

This implementation is more respectful of the standard
What do we think of using namespaces ? Sounds like a good thing to change everywhere tbh
Adding safemath would be great
We should use from starkware.cairo.common.bool import TRUE, FALSE if I'm looking correctly at latest changes
The storage_var should be called ERC4626_asset_ to fit OZ guidelines

Pet3ris commented 2 years ago

These implementations are awesome. Let me throw one more in the hat: https://github.com/auditless/cairo-erc4626

We follow the solmate impl.
Use TRUE, FALSE
Use ERC4626_ naming conventions

Like the idea of namespaces / safemath.

Pet3ris commented 2 years ago

@EvolveArt added your wishlist of safemath and namespaces:

https://github.com/auditless/cairo-erc4626

martriay commented 8 months ago

a reference implementation for Cairo 1: https://github.com/0xEniotna/ERC4626

VVander commented 4 weeks ago

Hello! Since STRK staking is coming soon, it would be great to have this moved up the priority list so that STRK LSTs can use it. Best we have at the moment is the ref impl mentioned above.