OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup
https://docs.openzeppelin.com/contracts-cairo
MIT License
802 stars 323 forks source link

Cairo 2.3.0 support #781

Closed julio4 closed 9 months ago

julio4 commented 9 months ago

šŸ§ Motivation From Scarb v2.3.0-rc0, Scarb vX.Y.Z matches Cairo vX.Y release. OpenZeppelin cairo contracts could follow the same standard for ease of use.

šŸ“ Details Starting from next version supporting Cairo v2.3.0-rc0

martriay commented 9 months ago

Why do you think this would be desirable?

julio4 commented 9 months ago

Aren't you following the current scarb versioning? openzeppelin = { git = "https://github.com/OpenZeppelin/cairo-contracts.git", tag = "v0.7.0" } for Scarb 0.7.0

Edit: it seems to be only a coincidence, sorry to have rushed to conclusion. Then I should rename issue "Cairo 2.3.0 support"

martriay commented 9 months ago

Yes it was a coincidence. We won't pair versioning with Scarb or Cairo, as Scarb did, because:

I frankly see little to no value and a bit of risk, as expressed above; but itā€™s ok if Scarb wants to experiment with this.

martriay commented 9 months ago

Closing this issue as duplicate of https://github.com/OpenZeppelin/cairo-contracts/issues/751. You can track our plans and progress in our public roadmap.