OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup
https://docs.openzeppelin.com/contracts-cairo
MIT License
802 stars 323 forks source link

Update Starknet book references #788

Closed martriay closed 8 months ago

martriay commented 9 months ago

For example the ones in the Security considerations section

Nonnyjoe commented 9 months ago

To be clear this issue is about updating the reference contracts in Starknet book to the latest Cairo version right? If yes, then I'll like to handle this task.

martriay commented 9 months ago

Yes, any OpenZeppelin code and links to our docs like

You can create your own custom solution or use existing templates like those provided by OpenZeppelin

Nonnyjoe commented 9 months ago

Okay that's fine. I'll check out the Starknet book repo, then reach out to the person in-charge, also possibly create an issue ASAP.

omarespejel commented 8 months ago

Thanks, @martriay. It seems you're looking at an older version of the Book. The current version is at book.starknet.io and we no longer have that chapter. We'll investigate why the previous version is still visible.

Thank you @Nonnyjoe for bringing this to my attention

martriay commented 8 months ago

@omarespejel should we still have an access control dedicated section with examples?

omarespejel commented 8 months ago

@martriay, I see the value in including it. However, we're aiming to keep Cairo-related content in the Cairo Book, specifically in the access control section. In your view, should we add more examples to the current version?

martriay commented 8 months ago

Access Control is 100% Starknet, there's no sender notion in Cairo.

This is what you just linked, it says Starknet everywhere:

image

omarespejel commented 8 months ago

Thank you @martriay, this is invaluable. We will open an issue in the Starknet Book to get contributors to write the Access Control section.

Nonnyjoe commented 8 months ago

@omarespejel could you please assign that to me, I'll like to work on that

martriay commented 8 months ago

I'll close this issue since there's no outdated references to fix anymore. Looking forward to the new content!

omarespejel commented 7 months ago

Thank you, @martriay and @Nonnyjoe, for bringing this important issue to our vision. We've responded by adding a chapter on it: Security Considerations Chapter, with credit to author @devnet0x.

We welcome any further insights or feedback!