OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup
https://docs.openzeppelin.com/contracts-cairo
MIT License
800 stars 322 forks source link

Add ERC1155 module, dual and interface with Component implementation #852

Closed cloudvenger closed 4 months ago

cloudvenger commented 6 months ago

Fixes #572

PR Checklist

martriay commented 5 months ago

Hello @cloudvenger, thanks for all the work put into this. As this is scheduled as part of our upcoming milestone and since we're way past the original agreed deadline (~3rd week of November 2023, or December ~15th as the latest extension) we'll be picking this up internally to completion. Thanks again for your contributions.

cloudvenger commented 5 months ago

Juste reading your message @martriay
I send you a Telegram message to explain myself on the subject and trying to find a solution to contribute

cloudvenger commented 5 months ago

To help to continue/finish the impl of ERC-1155 in component version, here is the list of what was done :

Remains to be done :

You can find a Smart Contract which used this erc1155 component version her : https://testnet.starkscan.co/contract/0x01115205424b7d08d8895dd0d5c60d6f7beb5def65c749898d0864823f3dbb43#overview

The Smart Contract is recognized as ERC-1155 on voyager blockchain explorer Important point : To be recognized as ERC-1155 Starkscan blockchain explorer, I needed to add the support interface of old ERC-1155 Interface 0xd9b67a26. I did not add it in OpenZepplin erc-1155 impl but I add it in the constructor of the Smart Contract which used erc-1155 openzepplin component.

If you are any question, do not hesitate @martriay

martriay commented 4 months ago

Superseded by #896