OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup
https://docs.openzeppelin.com/contracts-cairo
MIT License
813 stars 329 forks source link

Release v0.8.1 #868

Closed martriay closed 8 months ago

martriay commented 8 months ago

Should we update the class hashes in the codumentation in here as well?

Not really, this should be done whenever we update the compiler version, as documented. I'll try to exceptionally update them in here.

One suggestion, I think is worth creating the release branch PR from a fork, instead of directly pushing to the repo, because the docsite is automatically updated with the latter (it currently shows 0.8.1 even when the PR hasen't been reviewed), and this could be confusing to users.

this is the same reason we protected the branch. I think we should use an alternative branch, not depending on us creating the branch from a fork. I wonder whether we should change the docsite config so it pulls the tag instead of the commit branch. I think we need to think this further and I'd rather not block this release because of this.

ericnordelo commented 8 months ago

Not really, this should be done whenever we update the compiler version, as documented. I'll try to exceptionally update them in here.

But in this case, we are updating the compiler version from 2.3.1 to 2.4.1, right? I know not exactly in the PR, but the last class hashes documented were using 2.3.1 when the repo is now using 2.4.1.

martriay commented 8 months ago

Indeed. I was just stating that it's not the standard procedure to do it in these PRs.