Closed martriay closed 8 months ago
Not really, this should be done whenever we update the compiler version, as documented. I'll try to exceptionally update them in here.
But in this case, we are updating the compiler version from 2.3.1 to 2.4.1, right? I know not exactly in the PR, but the last class hashes documented were using 2.3.1 when the repo is now using 2.4.1.
Indeed. I was just stating that it's not the standard procedure to do it in these PRs.
Not really, this should be done whenever we update the compiler version, as documented. I'll try to exceptionally update them in here.
this is the same reason we protected the branch. I think we should use an alternative branch, not depending on us creating the branch from a fork. I wonder whether we should change the docsite config so it pulls the tag instead of the commit branch. I think we need to think this further and I'd rather not block this release because of this.