fix: Call corrections and removal of ABI annotations in SRC6Impl

OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup

https://docs.openzeppelin.com/contracts-cairo

MIT License

797 stars 322 forks source link

fix: Call corrections and removal of ABI annotations in SRC6Impl #888

Closed machuwey closed 5 months ago

machuwey commented 5 months ago

Fixes #887

Just went on and fixed the the few things that were causing the problem to initilize the project:

Deleted unnecesary .span()
Deleted wrong [abi(embed_v0)]etiquettes because the SRC6Impl shouldn't be exposed in the abi.

PR Checklist

[ ] Tests
[ ] Documentation
[ ] Added entry to CHANGELOG.md
[ ] Tried the feature on a public network

martriay commented 5 months ago

Thanks for doing this! But as mentioned in #871, this not the right fix. The contracts are fine, they're just not compatible with Cairo 2.5.0 (Scarb.toml specifies v2.4.1).

This issue is tracked in #877. We really appreciate contributions, next time please wait between creating an issue and opening a PR addressing it as indicated in our CONTRIBUTING guide, we don't want to waste your time.