OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup

https://docs.openzeppelin.com/contracts-cairo

MIT License

797 stars 321 forks source link

Document ERC721ReceiverComponent #945

Closed ericnordelo closed 3 months ago

ericnordelo commented 3 months ago

Fixes #913

This PR adds the missing documentation for the ERC721ReceiverComponent, and also fixes the name of the mixin implementation.

PR Checklist

[x] Tests
[x] Documentation
[x] Added entry to CHANGELOG.md
[ ] Tried the feature on a public network

ericnordelo commented 3 months ago

I think we can update Creating a token receiver contract to use ERC721ReceiverMixinImpl as well to clean up the snippet. WDYT?

The only issue I see with the approach is inconsistency. For example, the ERC721 in the same page is not using mixins, and I think we should update that as well. Let's let it for a different issue if you agree.

OpenZeppelin / cairo-contracts

Document ERC721ReceiverComponent #945

PR Checklist

948