search

OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup
https://docs.openzeppelin.com/contracts-cairo
MIT License
797 stars 320 forks source link

Add account usage guide #981

Closed andrew-fleming closed 1 month ago

andrew-fleming commented 2 months ago

Fixes #806.

PR Checklist

ericnordelo commented 1 month ago

I think this is ready to go, after agreeing on the last item.

What do you think about moving it to its own page under the Learn section? Or maybe changing the name of the inner section in the same page from "Usage" to something like "Sending transactions". We want users to be aware of this guide as easy as possbile.

andrew-fleming commented 1 month ago

I feel that this guide is super helpful, but not easy to find, since it is the last part of this page. What do you think about moving it to its own page under the Learn section? Or maybe changing the name of the inner section in the same page from "Usage" to something like "Sending transactions". We want users to be aware of this guide as easy as possbile.

I think changing the inner section to "Sending transactions" is much better than just "Usage". I'm not totally convinced it's the best approach. Maybe making this its own doc under Learn as you also suggested or even having it nested within the accounts module (alongside API Reference) would be the way to go. That said, I'm okay with using "Sending transactions" for now. This is your suggestion, but let me know if you disagree after seeing it