search

OpenZeppelin / chai-bn

Chai assertions for comparing arbitrary-precision integers using the bn.js library
MIT License
15 stars 21 forks source link

Change addProperty to overwriteProperty #1

Closed frangio closed 5 years ago

frangio commented 5 years ago

https://github.com/ZeppelinSolutions/chai-bn/blob/4c036a28bd5b5b3e7273199b9520ce788ab1a51d/chai-bn.js#L118

https://github.com/ZeppelinSolutions/chai-bn/blob/4c036a28bd5b5b3e7273199b9520ce788ab1a51d/chai-bn.js#L131

See overwriteProperty.

nventuro commented 5 years ago

Fixed in 2c9ce2b36f3f4a8c4af0f26aeda230074e5fcca8

frangio commented 5 years ago

By the way you can get GitHub to automatically close this by adding "Fixes #1" in the commit description, just as we do with PRs.

nventuro commented 5 years ago

I know, but I fixed those issues before I knew you opened issues here 😅