Closed ericglau closed 4 months ago
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@alloc/quick-lru@5.2.0, npm/@isaacs/cliui@8.0.2, npm/@jridgewell/gen-mapping@0.3.5, npm/@jridgewell/source-map@0.3.6, npm/@mapbox/node-pre-gyp@1.0.11, npm/@types/istanbul-lib-coverage@2.0.6, npm/@types/node@18.19.31, npm/camelcase@5.3.1, npm/cliui@5.0.0, npm/console-control-strings@1.1.0, npm/cross-spawn@6.0.5, npm/decamelize@1.2.0, npm/find-up@3.0.0, npm/glob@7.2.3, npm/minipass@5.0.0, npm/path-key@2.0.1, npm/string-width@3.1.0, npm/strip-ansi@5.2.0, npm/throat@4.1.0, npm/typescript@4.9.5, npm/wsrun@5.2.4, npm/yargs-parser@13.1.2
@andrew-fleming That sounds good to me! However, I would prefer for that to be in a separate PR, and perhaps (depending on timing) it may make sense to do this when hooks are available for the other contract kinds. I think the current PR is an improvement over the current state (and enables 0.12.0) and therefore makes sense on its own.
I would prefer for that to be in a separate PR, and perhaps (depending on timing) it may make sense to do this when hooks are available for the other contract kinds. I think the current PR is an improvement over the current state (and enables 0.12.0) and therefore makes sense on its own.
Sounds good on all accounts!
@ericnordelo @andrew-fleming I've added SNIP12-specific options as "Application Name" and "Application Version", and added checks to ensure these are not empty string. This PR is ready for re-review.