Closed ericnordelo closed 1 month ago
@ericnordelo You may need to regenerate snapshots using the yarn ava --update-snapshots
command and commit the .snap
files in addition to the .md
files. The .snap
files seem to be something like metadata.
packages/core-cairo
directoryyarn tsc -b
yarn ava --update-snapshots
.md
files, and if they look correct, commit the .md
and .snap
filesFor completeness, I would normally suggest to add a changelog entry in https://github.com/OpenZeppelin/contracts-wizard/blob/master/packages/core-cairo/CHANGELOG.md and bump the version in https://github.com/OpenZeppelin/contracts-wizard/blob/master/packages/core-cairo/package.json, so we can make a new release of the @openzeppelin/wizard-cairo
npm package. This isn't strictly necessary in this case though, since it seems the only change visible to the end user is the library version in the comment, and the Wizard UI itself does not consume this npm package.
There is the following error in the Scarb setup step in https://github.com/OpenZeppelin/contracts-wizard/actions/runs/10359200513/job/28675084025?pr=378:
Error: There was an error when restoring cache: failed to cache dependencies: unable to hash Scarb.toml file
There is the following error in the Scarb setup step in https://github.com/OpenZeppelin/contracts-wizard/actions/runs/10359200513/job/28675084025?pr=378:
This seems to be a warning labeled in the wrong way, that step passes, it looks like the workflow is failing because the compilation takes too much time?
It fails in the Run software-mansion/setup-scarb@v1
step though, which is before the Compile contracts
step.
It fails in the Run software-mansion/setup-scarb@v1 step though, which is before the Compile contracts step.
It seems to failed but it passes, the Error is a warning, notice that the setup-scarb step runs successfully
Oh I see what you mean. In this previous successful build on master
, that Error message also exists. But the compile step in that passing build completed in 6 minutes, while it timed out after 45 minutes here.
If I run a scarb build
locally with just one contract (keeping only packages/core-cairo/test_project/src/Contract1.cairo
and deleting the rest), it takes 69 seconds with the latest changes from this PR. Previously it only took 17 seconds.
Eric, I ran the test locally and they pass (after 20 minutes). I have removed the workflow at least temporarily to get the PR merged, later we can figure out what to do about it.
@ericglau any idea why tests are still failing after I updated the 0.14.0 version in all the test files?