search

OpenZeppelin / contracts-wizard

Interactive smart contract generator based on OpenZeppelin Contracts.
https://wizard.openzeppelin.com
MIT License
248 stars 137 forks source link

Add ERC721Enumerable #391

Closed immrsd closed 1 month ago

immrsd commented 1 month ago

Fixes #1131.

Test target has been compiled with no issues.

immrsd commented 1 month ago

Looks good, thanks! Just a few comments. Can you also add a changelog entry in an Unreleased section of packages/core-cairo/CHANGELOG.md?

Done!

ericnordelo commented 1 month ago

Hey @immrsd, the PR looks good. I want to confirm that you did run yarn run update_scarb_project to update the test_project/, and build with scarb build to ensure there are not warnings or compilation errors with the new addition. Let me know if that's the case.

immrsd commented 1 month ago

Hey @immrsd, the PR looks good. I want to confirm that you did run yarn run update_scarb_project to update the test_project/, and build with scarb build to ensure there are not warnings or compilation errors with the new addition. Let me know if that's the case.

Yes, I executed the script and built with scarb --release build, no compilation issues

image