OpenZeppelin / contracts-wizard

Interactive smart contract generator based on OpenZeppelin Contracts.
https://wizard.openzeppelin.com
MIT License
248 stars 137 forks source link

Bump cairo to v0.18.0 #399

Closed andrew-fleming closed 3 weeks ago

andrew-fleming commented 3 weeks ago

This PR proposes to move the votes logic to common-components. This PR also proposes to include votes functionality for erc721.

I ran yarn run update_scarb_project on the test project and compiled...after 24 short minutes, there are no errors or warnings :)

ericnordelo commented 3 weeks ago

Hey @ericglau I reviewed the output, refactored the hooks a bit, and compiled locally. Why can't I see the deploy preview though, does every commit need to be approved?. Note that is harder to review without it even for myself.

ericnordelo commented 3 weeks ago

Btw it took me 66 minutes to compile 😢

socket-security[bot] commented 3 weeks ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@openzeppelin/contracts-upgradeable@5.1.0 None 0 1.31 MB amxx
npm/@openzeppelin/contracts@5.1.0 None 0 1.97 MB ernestognw
npm/hardhat@2.22.14 None 0 2.62 MB alcuadrado, fvictorio, fzeoli, ...3 more
npm/jszip@3.10.1 None 0 762 kB stuk
npm/solidity-ast@0.4.59 None 0 237 kB frangio

🚮 Removed packages: npm/ethereum-cryptography@3.0.0

View full report↗︎

socket-security[bot] commented 3 weeks ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteCI
High CVE npm/rollup@2.79.2 🚫

View full report↗︎

Next steps

What is a CVE?

Contains a high severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/rollup@2.79.2
ericglau commented 3 weeks ago

The rollup issue does not look correct, as I don't see version 2.79.2 being used anywhere in the project.

@SocketSecurity ignore npm/rollup@2.79.2