:heavy_plus_sign: Add connect MetaMask modal

OpenZeppelin / ethernaut

Web3/Solidity based wargame

MIT License

1.98k stars 677 forks source link

:heavy_plus_sign: Add connect MetaMask modal #752

Closed GianfrancoBazzani closed 2 months ago

GianfrancoBazzani commented 2 months ago

closes: https://github.com/OpenZeppelin/ethernaut/issues/751

ericglau commented 2 months ago

Would it make sense to add a way to close the modal, in case the user is not interested in connecting at the moment and just wants to look around?

GianfrancoBazzani commented 2 months ago

Would it make sense to add a way to close the modal, in case the user is not interested in connecting at the moment and just wants to look around?

yes, absolutely! we have a similar behavior with networks being deprecated

xaler5 commented 2 months ago

The read-only mode was already existing whenever there was no web3 provider injected (different from having it but not being connected to).

In the former case, a warning is displayed to remember to the user that the game is on read-only mode. Can we keep the behaviour consistent with that ?

To see what I'm talking about you can for example joing the deploy preview from a mobile phone.