Closed eternauta1337 closed 2 years ago
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
This issue now has a funding of 750.0 DAI (750.0 USD @ $1.0/DAI) attached to it.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work has been started.
These users each claimed they can complete the work by 1 month, 3 weeks ago. Please review their action plans below:
1) jzarecta has applied to start work _(Funders only: approve worker | reject worker)_.
I am native spanish speaker has provided translation services for many projects including KDE, OpenOffice, and Apache software as well as on the crypto world to DASH, OpenLedger, Electrum wallet, and Edge Wallet.
Learn more on the Gitcoin Issue Details page.
2) hibeekaey has been approved to start work.
Use a localization plugin with a single localization mapping file
Learn more on the Gitcoin Issue Details page.
3) starsinmypockets has applied to start work _(Funders only: approve worker | reject worker)_.
I would like to have a go at this. I have worked with the localization scheme for the apostrophe cms (https://github.com/apostrophecms/apostrophe/blob/master/lib/modules/apostrophe-i18n/index.js) as well as with Drupal. My approach would be along these lines:
• create a utility function for use in templates to wrap strings • implement i18n using 3rd party library to access appropriate values for locale (for example i18n library via npm) • detect default language using third party library • store / lookup user-selected language via cookie • create UI element to allow users to switch preferred language • include tests of utility function, template behavior, and UI language switch
Learn more on the Gitcoin Issue Details page.
@ajsantander how can I reach your team?
Sorry @Jzarecta but @iamonuwa got to it first :) Looking forward to having you on some other bounties though!
@gitcoinbot work in progress. Sending in PR soon
I wonder if there is something I need to provide to get approved?
Thx @iamonuwa (and @Jzarecta nonetheless)! Looking forward to your work.
@ajsantander am currently working on the logic. I have added react-intl which is what am using. Added the language to the window global instance to be served together with the other variables inside the window instance. I have a slight issue. On the loadGameData middleware, I see that its loading the game data. I was thinking of adding an additional directory say en
for english, es
for spanish. Then each of the newly created directory will have the descriptions
folder as its content.
What do you think?
@ajsantander are you there?
Overriding bounty to submitted.
@ajsantander am currently working on the logic. I have added react-intl which is what am using. Added the language to the window global instance to be served together with the other variables inside the window instance. I have a slight issue. On the loadGameData middleware, I see that its loading the game data. I was thinking of adding an additional directory say
en
for english,es
for spanish. Then each of the newly created directory will have thedescriptions
folder as its content.What do you think?
@ajsantander are you there?
Yes! Sorry. These are busy days, you know, because devcon =/
I like the approach. Sounds good!
Cool then. Will be submitting a PR to add that.
@ajsantander please can you review? Added a new commit last night.
@ajsantander are you there?
Hey @iamonuwa I think @ajsantander will be able to review soon, devcon just wrapped up so assuming he's probably still getting back into the regular flow of things.
@iamonuwa @ajsantander Bumping this one... I'm still in a post-Devcon haze, I'm sure we'll get there sooner than later now 🙂
Still waiting on the team to give feedback
@ajsantander please review my latest PR
@ajsantander are you there? Still waiting for your feedback
Hey @ajsantander ! Gitcoin Ambassador here to ask if @iamonuwa 's has received feedback on his latest PR?
Hey @ajsantander, Ryan from Gitcoin here. Any word on this one? Feel free to reach out if you have any questions for me.
Hello! Yes, Sorry again for the delay. Reviewing the PR now...
hey @ajsantander from team gitcoin ! is there someone on your team who has the cycles to do some review? cc @iamonuwa
⚡️ A tip worth 750.00000 DAI (750.0 USD @ $1.0/DAI) has been granted to @iamonuwa for this issue from @ceresstation. ⚡️
Nice work @iamonuwa! Your tip has automatically been deposited in the ETH address we have on file.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
This Bounty has been completed.
Additional Tips for this Bounty:
Multilanguage support is now in master branch
Ethernaut should be available in other languages like Spanish or Chinese so that non-english speaking members of the community can have access to the resource.
This issue specifically refers to functionality and NOT content, i.e. just the dapp's generic ability to localize content and not the content in other specific languages itself.
The feature should allow to localize level description markdown flles as well as website elements such as titles, buttons, etc.
Ideally, all non-markdown localizations should be contained on a single localization mapping file.
The UI should include a button that allows a user to change the active language, and it should automatically detect the user's language.