OpenZeppelin / gsn-site

The Ethereum Gas Station Network Alliance Landing Page and Tools
MIT License
12 stars 15 forks source link

Review ABI usage in relayer and dapp tools #5

Open spalladino opened 5 years ago

spalladino commented 5 years ago

The relayer and dapp tools were developed with a slightly outdated version of the relayhub ABI. Go through all ABI calls and fix them to update them to the latest version of the relayhub.

Also, check whether the balance currently being displayed is correct. In particular, the dapp tool assumes that the recipient implements a getRecipientBalance method, which may not always be the case.

Reach out to Brendan or Chuck if help is needed.

frangio commented 4 years ago

The getRecipientBalance issue has been fixed in #6. The rest of the ABI usage hasn't been reviewed yet.