Reduce impact on contract size by modifying modifiers

[jnishiyama]

🧐 Motivation The idea here is to optimize contract size impact of modifiers by moving require statements to function that is separate from the modifier itself.

📝 Details I am fairly new to Web3 development, and I haven't checked throughout the repo, but in both OwnableUpgradeable and PausableUpgradeable the require statements are contained in the modifier. By simply creating a function that contains the require statement and calling it from the modifier, we can reduce the impact on the overall contract size of contracts using these.

e.g.

    /**
     * @dev Throws if called by any account other than the owner.
     */
    function _onlyOwner() private view {
        require(owner() == _msgSender(), "Ownable: caller is not the owner");
    }

    /**
     * @dev Throws if called by any account other than the owner.
     */
    modifier onlyOwner() {
        _onlyOwner();
        _;
    }

Depending on how much the modifier is used, the size reduction can be significant.

I'd be happy to make a PR if necessary.

[Amxx]

Hello @jnishiyama

The code in this repo is transpired from the "OpenZeppelin/OpenZeppelin-contracts" repository. This issue, and any corresponding PR should be submitted there.

Hope to see you soon there.

[jnishiyama]

Understood, leaving link to this issue on main repo for posterity: https://github.com/OpenZeppelin/openzeppelin-contracts/issues/3222