search

OpenZeppelin / openzeppelin-contracts-upgradeable

Upgradeable variant of OpenZeppelin Contracts, meant for use in upgradeable contracts.
https://openzeppelin.com/contracts
MIT License
1k stars 436 forks source link

Informational level Imporvement: `IERC721ReceiverUpgradeable.sol` comment error #190

Closed mr-dddt closed 1 year ago

mr-dddt commented 1 year ago

There is a comment mistake for the IERC721ReceiverUpgradeable.sol

https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/dd8ca8adc47624c5c5e2f4d412f5f421951dcc25/contracts/token/ERC721/IERC721ReceiverUpgradeable.sol#L19

change the comment of IERC721Receiver.onERC721Received.selector -> IERC721ReceiverUpgradeable.onERC721Received.selector

SantiagoDevRel commented 1 year ago

@Daniel-Verilog I just watched the same error, it wasn't compiling my staking contract, hopefully, they will fix it.

mr-dddt commented 1 year ago

@Daniel-Verilog I just watched the same error, it wasn't compiling my staking contract, hopefully, they will fix it.

just saw your reply, yes, if u implemented it wrong then this will cause compilation issues. If you still have problem, feel free to contact me through email: daniel.t@verilog.solutions

frangio commented 1 year ago

The Solidity code in this repository is converted automatically. While we can reliably do this for the Solidity code, we can't do the same for the documentation, so they remain without renames.