ernestognw
commented
1 year ago We're adding custom behaviors to support both Truffle and Ethers while we're migrating. A couple of those things to consider are when finishing the migration are:
- Remove all the
DEPRECATEannotations for packages we still need - Remove high-level snapshot introduced in #4652 in favor of
loadFixture(if AccessManager doesn't consume theblock.timestampas we initially thought) - We'll need to support both ethers's
signersand Truffleaccountsin this line. We should removeaccountssupport eventually - See if we can get https://github.com/NomicFoundation/hardhat/pull/4449 and migrate
- Reconsider where to put
testCommutative
List of files to migrate:
test/access/AccessControl.behavior.js#4694test/access/AccessControl.test.js#4694test/access/extensions/AccessControlDefaultAdminRules.test.js#4694test/access/extensions/AccessControlEnumerable.test.js#4694test/access/manager/AccessManaged.test.js#4710test/access/manager/AccessManager.behavior.js#4710test/access/manager/AccessManager.test.js#4710test/access/manager/AuthorityUtils.test.js#4710test/access/Ownable2Step.test.js: #4657test/access/Ownable.test.js: #4657 #4710test/finance/VestingWallet.behavior.js#4723test/finance/VestingWallet.test.js#4723test/governance/extensions/GovernorERC721.test.js#4728test/governance/extensions/GovernorPreventLateQuorum.test.js#4728test/governance/extensions/GovernorStorage.test.js#4728test/governance/extensions/GovernorTimelockAccess.test.js#4728test/governance/extensions/GovernorTimelockCompound.test.js#4728test/governance/extensions/GovernorTimelockControl.test.js#4728test/governance/extensions/GovernorVotesQuorumFraction.test.js#4728test/governance/extensions/GovernorWithParams.test.js#4750test/governance/Governor.test.js#4728 #4750test/governance/TimelockController.test.js#4728test/governance/utils/EIP6372.behavior.js#4728test/governance/utils/Votes.behavior.js#4750 #4728test/governance/utils/Votes.test.js#4728test/helpers/access-manager.js#4710test/helpers/account.js#4732 #4737 #4746test/helpers/chainid.jstest/helpers/constants.js#4710 #4797test/helpers/create.js: #4689test/helpers/customError.js: deprecatedtest/helpers/deploy.jstest/helpers/eip712.js: #4689 #4749 #4750test/helpers/enums.js#4728#4797test/helpers/erc1967.js: #4689 #4746test/helpers/governance.js#4728test/helpers/iterate.jstest/helpers/namespaced-storage.js#4710test/helpers/math.js#4737 #4732test/helpers/methods.js: #4689test/helpers/sign.js#4749test/helpers/time.js#4728 #4773#4797test/helpers/txpool.js#4728test/metatx/ERC2771Context.test.js#4732 #4737test/metatx/ERC2771Forwarder.test.js#4732 #4737test/proxy/beacon/BeaconProxy.test.js#4746test/proxy/beacon/UpgradeableBeacon.test.js#4746test/proxy/Clones.behaviour.js#4746test/proxy/Clones.test.js#4746test/proxy/ERC1967/ERC1967Proxy.test.js#4746test/proxy/ERC1967/ERC1967Utils.test.js#4746test/proxy/Proxy.behaviour.js#4746test/proxy/transparent/ProxyAdmin.test.js#4746test/proxy/transparent/TransparentUpgradeableProxy.behaviour.js#4746test/proxy/transparent/TransparentUpgradeableProxy.test.js#4746test/proxy/utils/Initializable.test.js#4746test/proxy/utils/UUPSUpgradeable.test.js#4746test/token/common/ERC2981.behavior.js#4793test/token/ERC1155/ERC1155.behavior.js#4771test/token/ERC1155/ERC1155.test.js#4771test/token/ERC1155/extensions/ERC1155Burnable.test.js#4771test/token/ERC1155/extensions/ERC1155Pausable.test.js#4771test/token/ERC1155/extensions/ERC1155Supply.test.js#4771test/token/ERC1155/extensions/ERC1155URIStorage.test.js#4771test/token/ERC1155/utils/ERC1155Holder.test.js#4771test/token/ERC20/ERC20.behavior.js#4743test/token/ERC20/ERC20.test.js#4743test/token/ERC20/extensions/ERC20Burnable.behavior.js#4773test/token/ERC20/extensions/ERC20Burnable.test.js#4773test/token/ERC20/extensions/ERC20Capped.behavior.js#4773test/token/ERC20/extensions/ERC20Capped.test.js#4773test/token/ERC20/extensions/ERC20FlashMint.test.js#4773test/token/ERC20/extensions/ERC20Pausable.test.js#4773test/token/ERC20/extensions/ERC20Permit.test.js#4750 #4773test/token/ERC20/extensions/ERC20Votes.test.js#4750 #4728test/token/ERC20/extensions/ERC20Wrapper.test.js#4773test/token/ERC20/extensions/ERC4626.test.js#4773test/token/ERC20/utils/SafeERC20.test.js#4773test/token/ERC721/ERC721.behavior.js#4793test/token/ERC721/ERC721Enumerable.test.js#4793test/token/ERC721/ERC721.test.js#4793test/token/ERC721/extensions/ERC721Burnable.test.js#4793test/token/ERC721/extensions/ERC721Consecutive.test.js#4793test/token/ERC721/extensions/ERC721Pausable.test.js#4793test/token/ERC721/extensions/ERC721Royalty.test.js#4793test/token/ERC721/extensions/ERC721URIStorage.test.js#4793test/token/ERC721/extensions/ERC721Votes.test.js#4728test/token/ERC721/extensions/ERC721Wrapper.test.js#4793test/token/ERC721/utils/ERC721Holder.test.js#4793test/utils/Address.test.js#4743 #4739test/utils/Arrays.test.js#4736test/utils/Base64.test.js#4736test/utils/Context.behavior.js#4732 #4737test/utils/Context.test.js#4732 #4737test/utils/Create2.test.js#4736test/utils/cryptography/ECDSA.test.js#4749test/utils/cryptography/EIP712.test.js#4749 #4750test/utils/cryptography/MerkleProof.test.js: #4689test/utils/cryptography/MessageHashUtils.test.js#4749test/utils/cryptography/SignatureChecker.test.js#4749test/utils/introspection/ERC165Checker.test.js#4794test/utils/introspection/ERC165.test.js#4794test/utils/introspection/SupportsInterface.behavior.js#4694test/utils/math/Math.test.js#4769test/utils/math/SafeCast.test.js#4769test/utils/math/SignedMath.test.js#4769test/utils/Multicall.test.js#4736test/utils/Nonces.test.js#4736test/utils/Pausable.test.js#4736test/utils/ReentrancyGuard.test.js#4736test/utils/ShortStrings.test.js#4736test/utils/StorageSlot.test.js#4736test/utils/Strings.test.js#4736test/utils/structs/BitMap.test.js#4748test/utils/structs/Checkpoints.test.js#4748test/utils/structs/DoubleEndedQueue.test.js#4748test/utils/structs/EnumerableMap.behavior.js#4748test/utils/structs/EnumerableMap.test.js#4748test/utils/structs/EnumerableSet.behavior.js#4748test/utils/structs/EnumerableSet.test.js#4748test/utils/types/Time.test.js#4778List of related migrations
ethereumjsin favor ofethers's alternatives