search

OpenZeppelin / openzeppelin-contracts

OpenZeppelin Contracts is a library for secure smart contract development.
https://openzeppelin.com/contracts
MIT License
24.84k stars 11.78k forks source link

Implementation does not match the interface: function signatures #5263

Closed 0xferit closed 3 hours ago

0xferit commented 3 hours ago

ERC1155Holder implements IERC1155Receiver.

However, function signatures in implementation do not match the interface. See data location (calldata vs memory) and visibility (external vs public). This seems wrong, and I wanted to bring this to your attention to make sure this is intended.

Amxx commented 3 hours ago

Hello @0xferit

This has been raised many time. I'm sure you'll find an explanation if you run a search.

0xferit commented 1 hour ago

Right. Thanks for the response. @Amxx

Here is one of them: https://github.com/OpenZeppelin/openzeppelin-contracts/issues/4811