`memory` --> `calldata` for read-only function params

OpenZeppelin / openzeppelin-contracts

OpenZeppelin Contracts is a library for secure smart contract development.

https://openzeppelin.com/contracts

MIT License

25k stars 11.81k forks source link

`memory` --> `calldata` for read-only function params #5293

Closed abhi3700 closed 2 weeks ago

abhi3700 commented 2 weeks ago

Fixes #5291

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: abe27cbd2f3a1f238174be4e2dda3aac6fda841f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

abhi3700 commented 2 weeks ago

The Github CI/CD tests are failing because of following error.

Using Node.js v22.11.0

Downloading compiler 0.8.24
TypeError: Member "recover" not found or not visible after argument-dependent lookup in type(library ECDSA).
  --> contracts/mocks/EIP712Verifier.sol:13:35:
   |
13 |         address recoveredSigner = ECDSA.recover(digest, signature);
   |                                   ^^^^^^^^^^^^^

Error HH600: Compilation failed

It doesn't make sense to me as in my VSCode, the method is valid. I am not sure what am I missing 🤔 .