search

OpenZeppelin / openzeppelin-contracts

OpenZeppelin Contracts is a library for secure smart contract development.
https://openzeppelin.com/contracts
MIT License
24.98k stars 11.8k forks source link

Document voting counting until casted in GovernorCountingOverridable #5309

Closed ernestognw closed 8 hours ago

ernestognw commented 2 days ago

Fixes L-04

Although we're not changing the code, it's true that more explicit documentation is required

PR Checklist

changeset-bot[bot] commented 2 days ago

⚠️ No Changeset found

Latest commit: 785940737f8374bb996a4c8042a135fd6a4e41ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ernestognw commented 2 days ago

Right, I removed the NatSpec at the top of the contract and kept the two notes.