OpenZeppelin / openzeppelin-foundry-upgrades

Foundry library for deploying and managing upgradeable contracts
MIT License
182 stars 29 forks source link

Defender: proposeUpgrade fails if project path has a space #70

Closed ericglau closed 2 months ago

ericglau commented 2 months ago

If the project path has a space, Defender.proposeUpgrade fails with a message like:

    ├─ [0] VM::tryFfi(["bash", "-c", "npx @openzeppelin/defender-deploy-client-cli@0.0.1-alpha.7 proposeUpgrade --proxyAddress 0x... --newImplementationAddress 0x... --chainId 11155111 --contractArtifactFile /tmp/project - foundry defender/out/MyTokenV3.sol/MyTokenV3.json"])

...

script failed: revert: Failed to propose upgrade for proxy 0x...: /Users/eric/git/defender-cli/dist/commands/propose-upgrade.js:67
        throw new Error('The proposeUpgrade command does not take any arguments, only options.');

This occurs because the --contractArtifactFile option above does not have quotes around the path string.