Provider doesn't throw an exception on a reverted relayed call

OpenZeppelin / openzeppelin-gsn-provider

Web3 provider for the Gas Station Network

MIT License

39 stars 29 forks source link

Provider doesn't throw an exception on a reverted relayed call #21

Closed nventuro closed 5 years ago

nventuro commented 5 years ago

A relayed call may revert due to pre, post, or the actual revert call reverting, running out of gas, among others. This is indicated with a non-zero status value in the TransactionRelayed event.

The current behavior of the provider in this scenario is identical to that of a successful relayed call: no special logs are emitted, and no exceptions are raised. We should force users to explicitly handle this error condition by bubbling up the error.

spalladino commented 5 years ago

Could not reproduce. Added tests in 053af7463c7eebfbd06316097885ecf3b6116622.