Unify naming for logic contract in all projects

OpenZeppelin / openzeppelin-labs

A space for the community to interact and exchange ideas on the OpenZeppelin platform. Do not use in production!

https://openzeppelin.com/

MIT License

376 stars 116 forks source link

Unify naming for logic contract in all projects #100

Open maraoz opened 6 years ago

maraoz commented 6 years ago

We use various different names for the same concept:

implementation contract
behavior contract
logic contract

all of these refer to the contract the proxy delegates calls to. Unify naming in all repos. Also check and update posts in https://blog.zeppelinos.org/

My personal preference among these 3 names is "behavior".

spalladino commented 6 years ago

-1 to behavior, I'd prefer implementation or backing implementation

maraoz commented 6 years ago

Decided for "logic contract", from Elena's post. Will move forward replacing all occurrences.

maraoz commented 6 years ago

Just discussed this offline with @leanthebean, and we decided to only use the term "logic contract" in the context of talking about proxies. All other references (i.e in the cli help, and introductory guides) should be just "contracts" to avoid unnecessary confusion.

maraoz commented 6 years ago

Implemented in user-facing texts on cli in https://github.com/zeppelinos/zos-cli/pull/215. Moving the issue to next milestone to refactor internal naming too (didn't want to change API so close to releasing)