test against geth private node

OpenZeppelin / openzeppelin-labs

A space for the community to interact and exchange ideas on the OpenZeppelin platform. Do not use in production!

https://openzeppelin.com/

MIT License

376 stars 116 forks source link

test against geth private node #106

Closed xuesong-hu closed 6 years ago

xuesong-hu commented 6 years ago

When I run tests for upgradeability_ownership against a geth private node with mining enabled, it will fail. When the tests are run against ganache, they will pass without any complaints. The geth node version is instance: Geth/v1.8.2-stable/linux-amd64/go1.9.4

frangio commented 6 years ago

Thanks for reporting this @xuesong-hu! We do have an issue open for this over in https://github.com/zeppelinos/zos-lib/issues/10. We will probably do that soon in the official repo, and if it proves easy port it to this experimental repo.

Please feel free to contribute the Travis CI configuration yourself in a PR if we don't get to this soon enough.

facuspagnuolo commented 6 years ago

Closing in favour of zeppelinos/zos-lib#10