search

OpenZeppelin / openzeppelin-sdk

OpenZeppelin SDK repository for CLI and upgrades.js. No longer actively developed.
MIT License
431 stars 200 forks source link

Upgrades documentation example using SimpleProject out of date #1573

Open abcoathup opened 4 years ago

abcoathup commented 4 years ago

Reported by shark0der on Telegram

https://docs.openzeppelin.com/upgrades/2.8/ is the example on this page out of date? according to the tests, SimpleProject requires 3 parameters and the txDetails is the 3rd not the second as per example https://github.com/OpenZeppelin/openzeppelin-sdk/blob/b3e945251a7c786dbb8197cb7703acc8326f4a51/packages/lib/test/src/project/SimpleProject.test.js#L20 additionally, it requires a proxyAddress as string, not a proxy object/instance