Extend `verify` command to support contracts with solidity libraries

OpenZeppelin / openzeppelin-sdk

OpenZeppelin SDK repository for CLI and upgrades.js. No longer actively developed.

MIT License

431 stars 201 forks source link

Extend `verify` command to support contracts with solidity libraries #251

Open jbcarpanelli opened 6 years ago

jbcarpanelli commented 6 years ago

Etherscan has recently added a contract source code verification API feature. We should extend the current zos verify command functionality to verify contracts using this API, which means:

[x] Implement a new --api-key <api-key> option and add a link in the description of how to get an Etherscan API key.
[ ] Implement a new --solidity-libs [libName1 ... libNameN] option to support solidity libs (up to 10).

For further information, see: https://etherscan.io/apis#contracts

spalladino commented 5 years ago

@jcarpanelli can we close this issue, as was fixed in #413?

jbcarpanelli commented 5 years ago

@spalladino We still have to implement the --solidity-libs option. I would keep it open until someone implements it :slightly_smiling_face:.

spalladino commented 5 years ago

Got it. Can we add a small check to skip a contract with a friendly message "skipping verification since solidity libraries are not yet supported" if that's the case, until we implement it?