OpenZeppelin / openzeppelin-sdk

OpenZeppelin SDK repository for CLI and upgrades.js. No longer actively developed.
MIT License
433 stars 200 forks source link

Add interactivity to create2 command #831

Open crazyrabbitLTC opened 5 years ago

crazyrabbitLTC commented 5 years ago

In testing zos create2 I noticed that the interactive commands don't always work.

 ✘ dennisonzeppelin@Dennisons-MBP  ~/Documents/create2  zos push
Compiling contracts with Truffle...

Compiling your contracts...
===========================
> Compiling ./contracts/Demo.sol
> Compiling ./contracts/Migrations.sol
> Artifacts written to /Users/dennisonzeppelin/Documents/create2/build/contracts
> Compiled successfully using:
   - solc: 0.5.0+commit.1d4f565a.Emscripten.clang

? Select a network from the network list development
Validating contract Demo
Uploading Demo contract as Demo
Deploying logic contract for Demo
Created zos.dev-1556636315855.json
 dennisonzeppelin@Dennisons-MBP  ~/Documents/create2  zos create2 Demo --salt 12345
A network name must be provided to execute the requested action.
 ✘ dennisonzeppelin@Dennisons-MBP  ~/Documents/create2 

In this case zos push prompted me to select a network from a list, but zos create2 did not. I would expect the behavior to be uniform across commands that require a network.

crazyrabbitLTC commented 5 years ago

Image added for clarity. Screen Shot 2019-04-30 at 11 04 17 AM

spalladino commented 5 years ago

Indeed, we haven't added interactivity to create2. I'll try to tackle this soon, thanks for bringing it up!