search

OpenZeppelin / openzeppelin-sdk

OpenZeppelin SDK repository for CLI and upgrades.js. No longer actively developed.
MIT License
431 stars 200 forks source link

Verify proxy contracts on zos verify #937

Open spalladino opened 5 years ago

spalladino commented 5 years ago

Currently only logic contracts are verified. We should verify the proxy themselves as well.

ylv-io commented 5 years ago

Pretty sure that was request a couple times already.

abcoathup commented 5 years ago

Until oz verify automagically support verifying proxy contracts, how can we verify proxy contracts manually on Etherscan?

What compiler version, EVM version, optimizer settings are used?

https://github.com/OpenZeppelin/openzeppelin-sdk/issues/1183#issuecomment-524984084

abcoathup commented 4 years ago

Process to verify the proxy contract: https://forum.openzeppelin.com/t/verify-proxy-contract/1989

orenyodfat commented 4 years ago

does this is valid from AdminUpgradeabilityProxy which are deployed from other contracts ? e.g via app.sol https://github.com/OpenZeppelin/openzeppelin-sdk/blob/master/packages/lib/contracts/application/App.sol#L117 @abcoathup @spalladino

spalladino commented 4 years ago

@orenyodfat unfortunately no, the CLI only tracks contracts deployed from the CLI itself.