Extend expectEvent to check arrays of BigNumbers

OpenZeppelin / openzeppelin-test-helpers

Assertion library for Ethereum smart contract testing

https://docs.openzeppelin.com/test-helpers

MIT License

416 stars 132 forks source link

Extend expectEvent to check arrays of BigNumbers #1

Open nventuro opened 5 years ago

nventuro commented 5 years ago

See here for an instance where an event argument has a value with type uint64[3].

frangio commented 5 years ago

Can a contract return more levels of array nesting? Should we support that too?

alejoamiras commented 4 years ago

A contract can not support array nesting. I was looking forward the check of big numbers array too.

alejoamiras commented 4 years ago

I've started a draft PR: https://github.com/OpenZeppelin/openzeppelin-test-helpers/pull/106

Shadowfiend commented 4 years ago

Given the use of deep.equal for event parameters as of #112 , this might be implemented by switching to https://www.npmjs.com/package/deep-equal-extended, which supports BNs in deep equality checks.