search

OpenZeppelin / openzeppelin-test-helpers

Assertion library for Ethereum smart contract testing
https://docs.openzeppelin.com/test-helpers
MIT License
415 stars 132 forks source link

AvalancheGO #153

Closed echocharlie125 closed 2 years ago

echocharlie125 commented 3 years ago

I've got following messages using local AvalancheGO network (avsh) :

@openzeppelin/test-helpers WARN expectRevert: Assertions may yield false negatives!

Revert reason checks are only known to work on Ganache >=2.2.0, and the current node is coreth-v0.3.23.

If your node does support revert reasons, please let us know: https://github.com/OpenZeppelin/openzeppelin-test-helpers/issues/new

abcoathup commented 3 years ago

Hi @echocharlie125!

Thanks for the suggestion, it is really appreciated.

Does Avalanche Go support revert reasons?

Once we have more information, the project owner will then review your suggestion as soon as they can.

Please wait until we have discussed this idea before writing any code or submitting a Pull Request, so we can go through the design beforehand. We don’t want you to waste your time!

echocharlie125 commented 3 years ago

Hi Andrew,, Thanks for your reply. I am not a contributor to the Avalanche Project. Any idea i can "check" if AvalancheGo supports revert reasons ?

frangio commented 3 years ago

@echocharlie125 You can trigger a revert with revert reason in the console and show us the output. We need to see the error message.

israel-gonzalezmedina commented 2 years ago

I have the same problem @frangio and @abcoathup here is my output:

  Wrong kind of exception received
  + expected - actual

  -Transaction: 0xf4219d9d6e0dc92efd666b98265222361ce8adb9146f6ffbb64907cf25446e60 exited with an error (status 0). 
  -     Please check that the transaction:
  -     - satisfies all conditions set by Solidity `require` statements.
  -     - does not trigger a Solidity `revert` statement.
  +ERC20PresetMinterPauser: must have minter role to mint
frangio commented 2 years ago

That doesn't look like the same problem. Closing due to inactivity.