Remove gas price 0 to support deployment on a chain post-London fork

OpenZeppelin / openzeppelin-test-helpers

Assertion library for Ethereum smart contract testing

https://docs.openzeppelin.com/test-helpers

MIT License

416 stars 132 forks source link

Remove gas price 0 to support deployment on a chain post-London fork #170

Closed musnit closed 3 years ago

musnit commented 3 years ago

eip-1559 breaks gasPrice: 0 transactions - they get stuck in pending in geth

this fixes that by removing gasPrice: 0.

i'm not sure if this has any unwanted side-effects for users that are deploying to non-eip-1559 chains like local truffle/hardhat, and I haven't tested that, but it fixes issues with deploying to geth :)

frangio commented 3 years ago

I forgot about this PR and made this change independently in https://github.com/OpenZeppelin/openzeppelin-test-helpers/commit/b772290355f1fc53e879a1523a59247cbde718f8. Sorry!