search

OpenZeppelin / openzeppelin-test-helpers

Assertion library for Ethereum smart contract testing
https://docs.openzeppelin.com/test-helpers
MIT License
415 stars 132 forks source link

hope this project can continue #182

Open fjun99 opened 2 years ago

fjun99 commented 2 years ago

The helper in this project is very helpful.

Maybe we can continue to develop this project:

frangio commented 2 years ago

Hi @fjun99. Personally I feel this project needs to be rewritten from scratch in TypeScript, and that it should be compatible with Ethers.js as well as Web3.js and Truffle. It should also have a lot fewer dependencies, particularly someone working with Ethers.js should not have to install Web3.js or Truffle and vice versa.

The testing setup is slow and overly complicated. I don't think we need to have this many integration tests.

If someone wants to work on this, that would be awesome.

fjun99 commented 2 years ago

Hi @fjun99. Personally I feel this project needs to be rewritten from scratch in TypeScript, and that it should be compatible with Ethers.js as well as Web3.js and Truffle.

yes I agree. Typescript and ethers.

I adapted one or two js file in this project to ts for my own usage.

to work with

frangio commented 2 years ago

I have started a potential rewrite of the project. So far expectRevert and snapshot are built. I would propose as next step expectEvent.

https://github.com/OpenZeppelin/openzeppelin-test-helpers/tree/rewrite