search

OpenZeppelin / workshops

Code and slides for OpenZeppelin Workshops
428 stars 277 forks source link

fix: updates required for latest hardhat and defender versions #14

Closed ivelin closed 2 years ago

ivelin commented 2 years ago

See individual commit comments.

ivelin commented 2 years ago

Makes sense. Thank you for reviewing the PR.

On Fri, Nov 12, 2021 at 6:36 AM Martin Verzilli @.***> wrote:

@.**** requested changes on this pull request.

Thanks for the suggestions @ivelin https://github.com/ivelin! I wouldn't merge this telling people to npm update, since that really depends on the moment it is run. I prefer to pin the right versions on package.json so npm install will do the right thing.

In 05-upgrades-management/code/README.md https://github.com/OpenZeppelin/workshops/pull/14#discussion_r748250087:

@@ -10,14 +10,16 @@ Check out this folder to your local environment, and run:

npm install

+npm update

This is too disruptive and env dependent. Let's update the package.json instead

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenZeppelin/workshops/pull/14#pullrequestreview-804756637, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARBUFLLONNL7D2GXAY2AGDULUC6RANCNFSM5HQK5TLQ .

ivelin commented 2 years ago

Awesome, thanks!

On Mon, Nov 15, 2021 at 6:55 AM Martin Verzilli @.***> wrote:

Merged #14 https://github.com/OpenZeppelin/workshops/pull/14 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenZeppelin/workshops/pull/14#event-5618058872, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARBUFJP3ZYZ6APK5P3YVO3UMD7NXANCNFSM5HQK5TLQ .