search

OpenZesame / Zhip

iOS Wallet for Zilliqa
MIT License
35 stars 6 forks source link

Add support for address only QR codes #99

Closed snowsledge closed 5 years ago

snowsledge commented 5 years ago

Feature Request

Motivation Behind Feature

Currently, the ZHIP app supports auto-filling toAddr and amount for the User which is awesome because of its simplicity and ease-of-use to Users. However, it lacks the support for address only QR codes (with only toAddr field). This limits the capability of ZHIP being a universal iOS wallet for the whole Zilliqa ecosystem.

Example of QR Codes:

Feature Description

Allow the ZHIP QR decoder to be compatible with QR codes that only has the toAddr field.

Alternatives or Workarounds

Backwards compatibility by making amount field Optional.

Sajjon commented 5 years ago

Ah interesting! So how does this manifest itself? Is the scenario of Zhip app scanning a Moonlet QR code - which does not contain amount - resulting in the scan made by Zhip failing to fill in the address field?

Sajjon commented 5 years ago

@evesnow91 Han I fixed this in #101 , will be part of release :)