Total DPS and tag issues with recently supported minions (Holy Relic, Sentinel of Purity, Sentinel of Dominance)

[MMREstimate]

Here are some likely bugs with the reported damage of minions newly supported in today's update.

Issue 1

• The following abilities appear to be missing the Melee tag. For example, they do not benefit from Melee Physical Damage Support. Herald of Purity Sentinel of Purity: Slam Herald of Purity Sentinel of Purity: Crusade Slam Dominating Blow Sentinel of Dominance: Shield Charge Dominating Blow Sentinel of Dominance: Crusade Slam

  To reproduce:

  1. Open this POB pastebin build: https://pastebin.com/sV8XfYWs
  2. Click the Skills menu.
  3. Set Main Skill to Herald of Purity -> Slam.
  4. Enable Melee Physical Damage support. Note that the minion's damage is unchanged.
  5. Repeat steps 3-4 by changing Main Skill for each combination: Herald of Purity: Slam Herald of Purity: Crusade Slam Dominating Blow: Shield Charge Dominating Blow: Crusade Slam

  The expected behaviour is that each of these setups would cause the minion's damage to increase when Melee-tagged support gems are enabled.

Issue 2

• The following are cooldown abilities, but erroneously scale their printed DPS with increased minion attack/cast rate. Herald of Purity Sentinel of Purity: Crusade Slam Dominating Blow Sentinel of Dominance: Shield Charge Dominating Blow Sentinel of Dominance: Crusade Slam Summon Holy Relic: Nova

  To reproduce:

  1. Open this POB pastebin build: https://pastebin.com/sV8XfYWs
  2. Click the Skills menu.
  3. Set Main Skill to Herald of Purity -> Crusade Slam.
  4. Click the Tree menu.
  5. Allocate the "Minion Attack and Cast Speed" node near the center of the tree. Note that the minion's total DPS value increases.
  6. Repeat steps 2-5 for each combination: Herald of Purity: Crusade Slam Dominating Blow: Shield Charge Dominating Blow: Crusade Slam Summon Holy relic: Nova

  The expected behaviour is that increasing attack/cast speed in these setups would not affect the minion's total DPS, as each of these skills are cooldown-gated. Instead, only Average Hit damage should display (similar to other cooldown-gated damage skills, such as Frost Bomb).

Issue 3 (possible -- maybe not a bug, but worth checking)

• Summon Holy Relic Nova appears to have 0% base crit chance. I assume this is correct but it might be worth double-checking as it's unusual for summoned minions and not mentioned in the gem itself.

[Openarl]

Issue 1 is fixed in the next update. Issue 3 isn't a bug; that skill does indeed have 0% base crit chance.

Issue 2 actually applies to all skills with cooldowns; I've been planning to fix it for a while, but it isn't straightforward as I need to account for things like skill repeats (e.g Spell Echo).