search

Openarl / PathOfBuilding

Offline build planner for Path of Exile.
MIT License
2.16k stars 1.04k forks source link

Tectonic Slam DPS is overestimated #1480

Open YunYunHub opened 5 years ago

YunYunHub commented 5 years ago

Current behaviour: Tectonic Slam DPS is multiplied by 1.6 when endurance charges are used.

Correct behaviour: The DPS calculation should take into the 35% chance that the skill gem has to proc charged slam as follows:

Average % = (0.65 100%) + (0.35 160%) = 121%

With the merciless lab enchant: Average % = (0.12 160) + 0.88 ((0.65 100%) + (0.35 160%)) = (0.12 160%) + 0.88 (121%) = 125.68%

With the uber lab enchant: Average % = (0.2 160) + 0.8 ((0.65 100%) + (0.35 160%)) = (0.2 160%) + 0.8 (121%) = 128.8%

emptywalls commented 5 years ago

I came across this when comparing Tectonic vs Ground slam builds. Both of them seem to be broken due to the export script not accounting for all skill attributes? So Tectonic slam gets overestimated by 1.6/1.2 where Ground Slam does not take into account the 1.49 more when close modifier. This is quite a severely misleading difference!