search

Openarl / PathOfBuilding

Offline build planner for Path of Exile.
MIT License
2.15k stars 1.03k forks source link

Shockwave calculates DPS incorrectly #1592

Open AndresV-NV opened 5 years ago

AndresV-NV commented 5 years ago

Shockwave support calculates DPS based on attack speed. However, the skill has a cooldown. The displayed DPS should take this into consideration

dodspunkare commented 5 years ago

Additionally, the Shockwave Support gem in PoB lists an inherent Increased Cooldown Recovery Speed which is not present on the actual in-game gem.

AndresV-NV commented 5 years ago

Additionally, the Shockwave Support gem in PoB lists an inherent Increased Cooldown Recovery Speed which is not present on the actual in-game gem.

It is listed on the equipped skill in the character sheet however. PoB is entirely correct in this regard.

The issue is that PoB will show cyclone doubling it's DPS by using Shockwave when that is clearly not the case. When you run the numbers, slow attacks(Earthquake) will get a massive boost from Shockwave, but cyclone gets between 30% and 60% more damage depending on how well your attack speed matches the shockwave cooldown.

Since many builds will be running rage/rampage, this means there's almost always a case where Shockwave is not producing optimal DPS, but it's very hard to understand without a spreadsheet.

Calculating DPS should go as follows: attackRate = 1/attackSpeed optimalDPS = averageDamage / skillCooldown missedDPS = skillCooldown % MAX(attackRate, skillCooldown) dpsLossPercent = missedDPS / skillCooldown finalDPS = optimalDPS * (1 - dpsLossPercent)

This number should not only be shown on the left, but also used when calculating the top support gem in the dropdown for characters using skills with maces and staffs

AndresV-NV commented 5 years ago

Also worth noting that for attacks with speeds close to, but note quite double the cooldown of shockwave, you'll approach 50% less DPS than what is listed on the averageDamage calculation.