Openarl / PathOfBuilding

Offline build planner for Path of Exile.
MIT License
2.16k stars 1.04k forks source link

Triad grip not converting minion damage #1671

Open ljdduncan opened 5 years ago

ljdduncan commented 5 years ago

Triad grip is not converting skeleton or zombie damage fully to cold despite having 4 green sockets. Have not tested other conversions

Pastebin showing the current calc not converting https://pastebin.com/nxrjRXFR

davatan commented 5 years ago

Triad Grip isn't officially added into PoB yet.

That said, the line "Minions deal x% of physical damage as fire/cold/lightning damage" is written in blue, indicating it's implemented, but it does not perform the damage conversion. I have EE set for hit recently with fire damage, and the above line set to convert 100% of minion physical damage to lightning damage, but removing or adding placeholder gloves with the above line added to it does not change any damage numbers for any of the minions in my build. The Calc section also displays physical damage still being dealt by the minions.

https://pastebin.com/dpf3y7UW PoB with the placeholder "Triad Grip" gloves with "Minions deal 100% of physical damage as lightning damage", but not converting the damage.

gtosh4 commented 5 years ago

Changing it to

Minions have 100% of Physical Damage converted to Fire Damage

works for me. image

hunk3r commented 4 years ago

Changing it to

Minions have 100% of Physical Damage converted to Fire Damage

works for me. image

and how to change it in PoB?

hunk3r commented 4 years ago

Found Answer! You need to use Chernobog's Pillar and necromantic aegis! So you can change conversion to any element, incl. chaos. Unfortunately damage of my spiders was not increased :(

Ydoum commented 4 years ago

Any chance this unique can be properly implemented into the next release?

RJonesUSC commented 4 years ago

Changing it to

Minions have 100% of Physical Damage converted to Fire Damage

works for me. image

That works great, Thanks!

Ydoum commented 4 years ago

Or you could go the more interesting route to get it working:

https://github.com/Openarl/PathOfBuilding/issues/1742