Openarl / PathOfBuilding

Offline build planner for Path of Exile.
MIT License
2.16k stars 1.04k forks source link

Facebreaker #2062

Open jacobmeyer12 opened 3 years ago

jacobmeyer12 commented 3 years ago

I was try to compare the DPS of my build with a facebreaker and two-handed variants and was feeling like the numbers for the facebreakers were skewed and noticed the the facebreakers were taking the more multiplier for physical from 172% to 2352% with an 800% facebreaker which was making a huge difference in my numbers. I could be wrong on how the calculation is done but it seems wrong to me. I have included a screen shot of my dps calc with and without the facebreakers below.

Facebreaker DPS Bugged

ALT-F-X commented 3 years ago

This isn't really an issue with PoB's calculations but more with how it passes information to the user clearly (or in this case unclearly). To be clear before I start explaining, PoB is doing nothing wrong.

So one thing I want to point out is in your own example with Facebreakers removed the problem your describing is still happening just on a much smaller scale. 15+49+59 does not equal 172. But that's ok because that's just not how More modifiers are calculated and that's where the confusion comes in.

Here's the real formula: (1+.15)*(1+.49)*(1+.59) which equals 2.72. Which in turn is 100% (the amount of damage you normally do) +172% damage (The amount of more damage all More modifiers are giving you). The formula for this math comes from the wiki: https://pathofexile.gamepedia.com/Stat#more_vs_increased

To double check to see if the Facebreakers calculation is correct we can do the formula again (1+.15)*(1+.49)*(1+.59)*(1+8) which equals 24.52. Which in turn is 100% (the amount of damage you normally do) +2352% (the amount of more damage all More modifiers are giving you).

And hey!!! the numbers match PoB. I hope this helps.