Openarl / PathOfBuilding

Offline build planner for Path of Exile.
MIT License
2.15k stars 1.03k forks source link

Eater of Worlds Implicit Modifier "Increased maximum Energy Shield" Incorrectly Treated as Local Modifier #2112

Closed halfacandan closed 2 years ago

halfacandan commented 2 years ago

PoB Version: 2.17.1 Build link: https://pastebin.com/rtwWqq6R (Includes both the original and the "Fixed" version of the item)

When the "Glyph Mantle" body armour (see code section below) is imported into PoB (either manually or via the character import), the "11% increased maximum Energy Shield (implicit)" Eater of Worlds Implicit Modifier is treated as a local modifier on the item's Energy Shield value but in reality it is a global modifier. This can be seen in the two images below where the character's ES in Path of Exile is 7.642 whereas PoB calculates it as 7,366

02-PoE_Actual 01-PoB_Error

Amending the implict's text manually to ""11% increased global maximum Energy Shield (implicit)" corrects the error in PoB's ES calculation (as shown below).

03-PoB_Fixed

This appears to be another manifestation of the issue described in corrupt implicit modifiers in issue #1217

Item Class: Body Armours
Rarity: Rare
Glyph Mantle
Vaal Regalia
--------
Quality: +30% (augmented)
Energy Shield: 778 (augmented)
--------
Requirements:
Level: 68
Int: 194
--------
Sockets: R-B-B-B-W B 
--------
Item Level: 87
--------
11% increased maximum Energy Shield (implicit)
While a Unique Enemy is in your Presence, 22% increased Effect of your Curses (implicit)
--------
+90 to maximum Energy Shield
141% increased Energy Shield
53% faster start of Energy Shield Recharge
Regenerate 140.5 Life per second
+10% to Chaos Resistance
13% increased Stun and Block Recovery
Searing Exarch Item
Eater of Worlds Item
halfacandan commented 2 years ago

Sorry. Meant to log this on the Community PoB fork.