Openarl / PathOfBuilding

Offline build planner for Path of Exile.
MIT License
2.15k stars 1.04k forks source link

Minion Combat Buffs. Flesh Binder Ascendancy and Rallying Cry #338

Open HexTonkLys opened 7 years ago

HexTonkLys commented 7 years ago

Flesh Binder Ascendancy node physical damage reduction buff is not applied. Number of Zombies is correctly calculated but the resulting physical damage reduction from this node has not been applied for the player buff list. Chaos golem physical damage reduction working though.

Rallying Cry % increase damage to allies does not apply to zombies/skellingtons/srs as far as I can tell when enabling/disabling this skill in the skill tab.

Openarl commented 7 years ago

Rallying Cry will apply to minions in the next update, although there's still no support for the scaling damage portion.

Flesh Binder is much trickier to support, unfortunately; the Zombie limit is calculated after the Physical Damage Reduction is calculated, and long after the point at which minion stats are applied to the minion. Also, if the main skill isn't Raise Zombie then that limit isn't calculated at all. I don't think I can resolve this easily, but I'll try and look into it when I can.

HiPoEGH commented 6 years ago

Was going to submit similar bug report.

I know this might clutter the configuration page, but could we have a box "# of zombies you have summoned" or "# of zombies you own". Similar situation with spectres, skeletons, and possibly raging spirits. This could be useful to have for other minions in relation to the unique Femurs of the Saints.

That might be one way to workaround automatically calculating based off a max limit, and allows players to specify what they have at any given time.