search

Openarl / PathOfBuilding

Offline build planner for Path of Exile.
MIT License
2.16k stars 1.04k forks source link

Intimidate calculations #781

Closed LilyMakesGames closed 6 years ago

LilyMakesGames commented 6 years ago

https://pathofexile.gamepedia.com/Intimidate

Intimidate doesn't proc on RF or Scorching Ray or any skill that doesn't "hit", but if you mark the Intimidate, it still adds +10% damage on the tooltip. This can cause confusion with some players who are planning new builds.

master2080 commented 6 years ago

What's your point here? You can also mark shock and many other things, they are there in case you want the effect added, it doesn't have to be related to RF at all.

LilyMakesGames commented 6 years ago

The DPS calculations using the Intimidate is adding 10% dmg even when it shouldn't, the game doesn't work like that. It would be the same as if the "was hit by Lightning" added the 40% damage even when the build doesn't have EE, but the tool check for EE before the calcs, it should check the skill before the Intimidate calcs too. The Intimidate doesn't affect skills that don't "hit", so if a player has the Belt of the Deceiver, all skills should add the 10% bonus damage to the DPS tooltip, except the ones that doesn't hit.

The whole point of having a tool to plan a build and test different sets of equipment is not having to buy it in-game. If something is wrong in the calculations, it has to be fixed.

Thirsk commented 6 years ago

This is an issue, but not for the reason YurihOI seems to think it is. It has nothing to do with a skill's ability to proc Intimidate (if you manually set it as active, the program should consider it to be active regardless of your ability to proc it) and more to do with the fact that 3.1.0 changed it so Intimidate now causes enemies to take 10% increased Attack Damage. Path of Building is still applying the increase to spell damage as well, which is simply an oversight.

jtuc commented 6 years ago

Is "Attack Damage" the same thing as damage from hits? If so, fixing this might be as simple as changing Intimidate from a DamageTaken mod to DamageTakenWhenHit, assuming we don't mind 2.6 calcs being inaccurate.

LilyMakesGames commented 6 years ago

Thank you Thirsk, it's attack damage and not just damage from any hit. Just checked again on PoE Wiki

Openarl commented 6 years ago

This is finally fixed in the next update. Sorry for the delay!