search

Opencast-Moodle / moodle-block_opencast

Moodle block plugin which can be used to link Moodle courses to Opencast series. Teachers can use this block to upload videos to Moodle which are then transmitted to Opencast and processed there afterwards.
22 stars 27 forks source link

Make sure teachers can't upload videos into arbitrary series in single-upload #363

Closed justusdieckmann closed 7 months ago

justusdieckmann commented 8 months ago

By only accepting the series param if $courseid==$SITE->id.

ferishili commented 7 months ago

@NinaHerrmann did you read my review? Or did you just ignore it?

NinaHerrmann commented 7 months ago

As far as I can see you did not do any review on this PR, but mentioned it in the other PR?

NinaHerrmann commented 7 months ago

image

ferishili commented 7 months ago

Screenshot 2024-03-18 at 10 38 15

Yes I did!

ferishili commented 7 months ago

I would like to offer a meeting for you and Justus to explain the whole situation. Just let me know!

ferishili commented 7 months ago

Screenshot 2024-03-18 at 10 43 10 A better view of the history! and the review request!

NinaHerrmann commented 7 months ago

ah. If you are doing a review you need to press submit. Otherwise no one sees your review :)

ferishili commented 7 months ago

I did, and that is why it says ferishili started a review :-)

EDIT: you were right, the submit was missing. I am looking forward to clear this matter!

ferishili commented 7 months ago

I am reverting it back before people cherry pick that, to make sure we are at the same page!