search

Opencast-Moodle / moodle-filter_opencast

Filter to embed Opencast videos in Moodle content
GNU General Public License v3.0
9 stars 9 forks source link

Handling of already logged in state #5

Closed tobiasreischmann closed 4 years ago

tobiasreischmann commented 6 years ago

We have to think about the check for existing cookies here. This could be problematic, if opencast and moodle run on different servers.

https://github.com/TamaraGunkel/moodle-filter_opencastfilter/blob/abed94061cd2042d0814606e01f7d766ef522456/filter.php#L57

TamaraGunkel commented 6 years ago

Is this issue still relevant? It should be irrelevant if opencast and moodle run on different servers because the cookies are saved in the browser, shouldn't it?

loewis commented 6 years ago

I think the test for the existing cookie should be dropped. If Opencast runs on a separate server, the browser will refuse to the send the cookie to Moodle, so you cannot check whether the cookie is set, anyway. If they run on the same server, it might be worse: the session might be expired even though the cookie is still present. I can't see a problem with logging in every time the page is rendered.

NinaHerrmann commented 4 years ago

Will be dropped due to previous arguments, and no complaints.