Opencast-Moodle / moodle-mod_opencast

Moodle activity plugin which can be used to display and view Opencast episodes and series in Moodle. Teachers can link the activity to an existing Opencast episode or series and an embedded player allows students to watch these videos directly in Moodle.
Other
4 stars 7 forks source link

The visibility of the video is not checked! (BUG?) #25

Closed ferishili closed 2 years ago

ferishili commented 2 years ago

No matter which visibility status the video in the block_opencast has, the video will be displayed in this plugin, which brings a lots of confusion.

How to produce:

As a teacher you are able to change the visibility of a video in block_opencast to 3 different states, (visible, invisible and group visibility). If a teacher makes a video invisible to all students, that means it should not be displayed! However in this case that does not happen in this plugin as well as the filter/repository plugin.

Solution

There has to be a some sort of ACL/visiblity check that is currently being used in block_opencast, to decided whether to display the video to the current user or not!

mtneug commented 2 years ago

I can understand the confusion. Currently, the visibility should be disabled for non-LTI use cases. The idea is not to sync and rely on Opencast ACLs but instead use Moodle-native methods on activity level. This is the way any activity works in Moodle. This effectively means that Opencast delegates the decision of whether to display the video to a user or not to Moodle.

That being said, if you exclusively use the activity to embed a whole series, you cannot hide individual videos. Currently, users would have to embed individual videos and set visibility on those. IMO this model is easy to understand and consistent with all other Moodle activities. If the Moodle plugin should get a feature to hide individual videos in a series embedding, I would still argue not to use Opencast ACLs and instead store this information in Moodle.

ferishili commented 2 years ago

Thank you for your clarification @mtneug. I close this issue based on the decision made.